From 9cc82874a1b45ab2e75f38096c9f37c7d5a406f3 Mon Sep 17 00:00:00 2001
From: Harald Pfeiffer <coding@lirion.de>
Date: Sun, 14 Apr 2024 21:30:38 +0200
Subject: Code fixes

---
 roles/patch_debian/tasks/main.yaml | 4 ----
 roles/patch_redhat/tasks/main.yaml | 4 ----
 roles/patch_suse/tasks/main.yaml   | 6 ------
 3 files changed, 14 deletions(-)

(limited to 'roles')

diff --git a/roles/patch_debian/tasks/main.yaml b/roles/patch_debian/tasks/main.yaml
index fab61ab..9d96a4e 100644
--- a/roles/patch_debian/tasks/main.yaml
+++ b/roles/patch_debian/tasks/main.yaml
@@ -55,10 +55,6 @@
       ansible.builtin.stat:
         path: /usr/sbin/needrestart
       register: nrex
-      ignore_errors: "yes"
-      no_log: true
-      failed_when: false
-      changed_when: false
     - name: Check for outdated kernel
       ansible.builtin.command: /usr/sbin/needrestart -pk
       register: kernout
diff --git a/roles/patch_redhat/tasks/main.yaml b/roles/patch_redhat/tasks/main.yaml
index 45d9e18..7f200e7 100644
--- a/roles/patch_redhat/tasks/main.yaml
+++ b/roles/patch_redhat/tasks/main.yaml
@@ -28,9 +28,6 @@
       ansible.builtin.stat:
         path: /usr/bin/rkhunter
       register: rkhex
-      ignore_errors: true
-      no_log: true
-      changed_when: false
     - name: RKhunter pre-check
       ansible.builtin.command: rkhunter -c --sk --rwo --ns
       become: true
@@ -61,7 +58,6 @@
       # "yum needs-restarting still works on RHEL 8, and "needs-restarting" is obsolete
       # On major releases >= 9 you may want to create an alternative for symlinking yum to dnf
       ansible.builtin.command: yum needs-restarting -r
-      ignore_errors: "yes"
       register: nr
       changed_when: false
       failed_when: false
diff --git a/roles/patch_suse/tasks/main.yaml b/roles/patch_suse/tasks/main.yaml
index cd5a4c5..db15d75 100644
--- a/roles/patch_suse/tasks/main.yaml
+++ b/roles/patch_suse/tasks/main.yaml
@@ -8,12 +8,6 @@
   ansible.builtin.stat:
     path: /usr/bin/rkhunter
   register: rkhex
-  ignore_errors: true
-  no_log: true
-  # yum always tosses this arbitrary extra line at you, a simple tr -s does not eradicate it, so - well,
-  # 0 and 1 are fine. As explained above, the RC is worthless when run through ansible.
-  changed_when: false
-  notify: "rkhunter execution"
 - name: Update zypper cache (SUSE)
   # we cannot cheat like we did with yum: we need to update any package to refresh the cache with the zypper module. Hence falling back
   # to shell.
-- 
cgit v1.2.3